Check zvols existence in zfsmanager #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can see "Error converting ... to zfs zvol ...: qemu-img failed: exit status 1, qemu-img: Could not open '...': Could not open '...': No such file or directory". We rely onto fsnotify and mdev to properly create symlinks to zvols, but seems we should check existence explicitly and publish only if we have zvol. Mdev log indicates that we do add-remove-add sequence, seems we should enforce sequence handling for mdev. Also we should not use persist publisher as devices may changed on reboot and should align Key to not have '/' which leads to problems with publishing. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
| func (status ZVolStatus) Key() string { | ||
| return status.Device | ||
| return strings.ReplaceAll(status.Dataset, "/", "_") |
There was a problem hiding this comment.
How did the old code work at all? Did it fail to write the checkpoint files inside pubsub but continued anyhow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can see "Error converting ... to zfs zvol ...: qemu-img failed: exit
status 1, qemu-img: Could not open '...': Could not open '...': No such
file or directory". We rely onto fsnotify and mdev to properly create
symlinks to zvols, but seems we should check existence explicitly and
publish only if we have zvol.
Mdev log indicates that we do add-remove-add sequence, seems we should
enforce sequence handling for mdev.
Also we should not use persist publisher as devices may changed on
reboot and should align Key to not have '/' which leads to problems with
publishing.
Signed-off-by: Petr Fedchenkov giggsoff@gmail.com