Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update containerd runtime to v2 #2719

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Conversation

giggsoff
Copy link
Contributor

@giggsoff giggsoff commented Jul 15, 2022

Containerd runtime v1 is deprecated and we use v2 runtime for linuxkit
services. Let's move to runtime v2 in pillar and replace v1 shim with
empty file to reduce space usage. Also version 1 of config.toml is
deprecated, we should move to version 2.

When run app instance on EVE-OS:
Before:

WARN[2022-07-20T16:07:20.654542386Z] runtime v1 is deprecated since containerd v1.4, consider using runtime v2
INFO[2022-07-20T16:07:20.671019410Z] shim containerd-shim started                  address=/containerd-shim/878eca779708a61fdd37aa98307e86c10c8efc9a8845e0587ff9c10d627e3179.sock debug=false pid=3151

After:

time="2022-07-20T16:12:07.500883005Z" level=info msg="starting signal loop" namespace=eve-user-apps path=/run/containerd/io.containerd.runtime.v2.task/eve-user-apps/774d8a63-6c63-4d7b-9a49-f90b1b3041bc.1.1 pid=3611

Containerd runtime v1 is deprecated and we use v2 runtime for linuxkit
services. Let's move to runtime v2 in pillar and replace v1 shim with
empty file to reduce space usage. Also version 1 of config.toml is
deprecated, we should move to version 2.

Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
Copy link
Contributor

@zededa-yuri zededa-yuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except that it would be good to document how you verified this change. E.g. a chapter "testing done" in the PR description

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Passes Eden and ztests.

@eriknordmark eriknordmark merged commit 2c50626 into lf-edge:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants