separate steps for generating rootfs #2958
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not change anything in the output, only in the interim steps.
Current
Currently, we generate the
rootfs.img
by callingmakerootfs.sh
, which calls (simplified):In other words, we build the OS root filesystem (left hand side of above) and pipe the tar stream to the container that creates squashfs (or ext4).
This works, but has two shortcomings:
Proposed
This PR breaks the above down into 2 steps:
rootfs.tar
fileThe
rootfs.tar
is in thedist/<arch>/<release>/
directory, but not in theinstaller/
subdir, as we do not need the tar file artifact in the final eve image.A next step PR will add scanners, initial for an SBoM which will be included in
installer/
and thus in the resulting image, but possibly also in other places (release artifacts), and future security scanners.How
Change:
tools/makerootfs.sh
to have 3 different operating modes, as well as usegetopt
to parse the CLI flagsMakefile
to add arootfstar
target and several target changesdocs/BUILD.md
to describe the new usage