Move measure-config to the bottom of the list #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error is still present. |
mikem-zed
changed the title
eriknordmark
approved these changes
Feb 2, 2023
this change doesn't fix a problem completely because we generate certificates on TPM when pillar starts. so this bug was always here. However we do not run live images in production so we never seen it before |
OK, but this order still makes more sense to me. |
Any container that modifies /config must be run before measure-config Just in case move it to the end of the list Signed-off-by: Mikhail Malyshev <mikem@zededa.com>
mikem-zed
force-pushed
the
mikem/pcr14-fix
branch
from
058d375 to
824082a
Compare
mikem-zed
changed the title
eriknordmark
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be quite risky to fix the original issue because a lot of logic must be moved
This is not really and issue but I have created a PR to move measure-config down in the list
Signed-off-by: Mikhail Malyshev mikem@zededa.com