Switch to miekg/dns #3096
Switch to miekg/dns #3096
Conversation
christoph-zededa
force-pushed
the
use_miekg_dns_newgo
branch
from
d604619 to
b56ff6a
Compare
christoph-zededa
force-pushed
the
use_miekg_dns_newgo
branch
5 times, most recently
from
98e9f39 to
66d86d2
Compare
christoph-zededa
force-pushed
the
use_miekg_dns_newgo
branch
from
66d86d2 to
21bfe24
Compare
christoph-zededa
force-pushed
the
use_miekg_dns_newgo
branch
from
21bfe24 to
dfe51b9
Compare
christoph-zededa
force-pushed
the
use_miekg_dns_newgo
branch
2 times, most recently
from
bae9362 to
38bfe8e
Compare
pkg/pillar/devicenetwork/dns.go
Outdated
| } | ||
|
|
||
| // ResolveWithPortsLambda resolves a domain by using source IPs and dns servers from DeviceNetworkStatus as a resolver func ResolveWithSrcIP can be used | ||
| func ResolveWithPortsLambda(domain string, dns types.DeviceNetworkStatus, resolve func(string, net.IP, net.IP) ([]DNSResponse, error)) ([]DNSResponse, []error) { |
There was a problem hiding this comment.
We do not really have coding style documented anywhere (mostly relying on go fmt), but personally I try to avoid long lines for better readability (my limit is 90 characters at most, but anything below 100 is fine IMHO).
There was a problem hiding this comment.
Done; perhaps we should integrate https://github.com/segmentio/golines into our build
There was a problem hiding this comment.
Looks interesting.
Or maybe just having a Yetus complain for a very long line, not sure if there is an option for that.
to make it more readable Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
force-pushed
the
use_miekg_dns_newgo
branch
from
38bfe8e to
94905bc
Compare
this allows us to set the source interface when doing DNS requests go-dns-resolver itself is using miekg/dns under the hood, so now nim is using it directly instead Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
force-pushed
the
use_miekg_dns_newgo
branch
from
94905bc to
26e52e7
Compare
| ttlSec = int(dnsResponses[0].TTL) | ||
| lookupIPaddr = dnsResponses[0].IP.String() |
There was a problem hiding this comment.
Finally see the complete panic stacktrace from the ztests run and it says
2023-03-30T17:12:55Z,pillar;panic: runtime error: index out of range [0] with length 0
2023-03-30T17:12:55Z,pillar;
2023-03-30T17:12:55Z,pillar;goroutine 512 [running]:
2023-03-30T17:12:55Z,pillar;github.com/lf-edge/eve/pkg/pillar/cmd/nim.(*nim).controllerDNSCache(0xc00035f400, {0xc000c1b200, 0xa0, 0x200}, {0xc000fbf200, 0x19, 0x200}, {0xc002376d60?, 0xc1018bbeb05b9c8e?})
2023-03-30T17:12:55Z,pillar; /pillar/cmd/nim/controllerdns.go:113 +0x387
2023-03-30T17:12:55Z,pillar;github.com/lf-edge/eve/pkg/pillar/cmd/nim.(*nim).queryControllerDNS(0xc00035f400)
2023-03-30T17:12:55Z,pillar; /pillar/cmd/nim/controllerdns.go:65 +0x3d6
2023-03-30T17:12:55Z,pillar;created by github.com/lf-edge/eve/pkg/pillar/cmd/nim.(*nim).run.func1
2023-03-30T17:12:55Z,pillar; /pillar/cmd/nim/nim.go:316 +0x196
Instead of the various checks (and these missing ones) for len(dnsResponses) == 0, it would be easier to read if there was a single if (len(dnsResponses) == 0 block here.
Also, if we get multiple responses shouldn't we use all of them? (I didn't check that the old dns code did when multiple responses for a name).
prepare by splitting controllerDNSCache into pieces to make it more readable
switch from go-dns-resolver to miekg/dns
this allows us to set the source interface when doing
DNS requests
go-dns-resolver itself is using miekg/dns under the hood,
so now nim is using it directly instead