downloader: Add the image URL into the error message. #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Almost good. |
In the case the URL of the image cannot be parsed for any reason, put it to the error message, so the user can see what can be the issue. Signed-off-by: Nikolay Martyanov <nikolay@zededa.com>
OhmSpectator
force-pushed
the
feature/add-image-url-to-error
branch
from
ec30fd6 to
88f1b7e
Compare
|
Print only the error returned by the ociRepositorySplit function. |
I can check it if you want. But the bug I'm fixing in the scope of this PR is an error in the debug message on the OCI URLs handling (previously it printed an empty string). It's requested by the CS team, See EV-383 for the details. |
|
This one PR is a request by the CS team: show the correct url on error path. I merge this since the change does exactly what was requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case the URL of the image cannot be parsed for any reason, put it to the error message, so the user can see what can be the issue.