Fix getIfNameListForLLOrIfname #3106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is supposed to accept either a port logical label or an interface name. Uplink probing refactoring broke this function and it stopped recognizing interface name as the input argument. This matters when device model contains port whose interface name and logical label differ from each other. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
fix-IfNameList
branch
from
373d48f to
76cc210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function is supposed to accept either a port logical label or an interface name. Uplink probing refactoring broke this function and it stopped recognizing interface name as the input argument. This matters when device model contains port whose interface name and logical label differ from each other.