pillar/zedagent: prevent possible crash if 'locConfig' is set to nil #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a possible race between checking the locConfig variable and passing it to the function which does not expect nil. This patch fixes possible crash if config re-fetched, locConfig is set to nil but goroutine was scheduled for execution. To prevent a crash use cached value. Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a possible race between checking the locConfig variable and passing it to the function which does not expect nil.
This patch fixes possible crash if config re-fetched, locConfig is set to nil but goroutine was scheduled for execution.
To prevent a crash use cached value.