Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to collect all source code for the packages used by eve #3121

Merged
merged 1 commit into from
Mar 31, 2023
Merged

to collect all source code for the packages used by eve #3121

merged 1 commit into from
Mar 31, 2023

Conversation

yash-zededa
Copy link
Collaborator

  • this metadata is required for sBOM process

@yash-zededa
Copy link
Collaborator Author

@deitch @dautovri please review

deitch
deitch requested changes Mar 27, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
eriknordmark
eriknordmark reviewed Mar 28, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
eriknordmark
eriknordmark reviewed Mar 28, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@eriknordmark eriknordmark requested a review from dautovri March 28, 2023 07:12
@eriknordmark eriknordmark changed the title to generate metadata for the packages used by eve to collect all source code for the packages used by eve Mar 29, 2023
deitch
deitch reviewed Mar 29, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
deitch
deitch requested changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
deitch
deitch approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deitch
Copy link
Contributor

deitch commented Mar 29, 2023

You need to sign the DCO

eriknordmark
eriknordmark approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eriknordmark
eriknordmark requested changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that all of the commits should be squashed before we can merge this.

@yash-zededa yash-zededa reopened this Mar 30, 2023
@yash-zededa
used gosources target for installing the utility and remove of the ec…
14f26af 
…ho command

Signed-off-by: yash-zededa <yash@zededa.com>

path variable for the go-sources binary

Signed-off-by: yash-zededa <yash@zededa.com>

minor fix in the Makefile

Signed-off-by: yash-zededa <yash@zededa.com>

fixing the CR, version and use of BUILD_DIR for file generation

Signed-off-by: yash-zededa <yash@zededa.com>

using go-sources utility in Makefile

Signed-off-by: yash-zededa <yash@zededa.com>

removed verbose logging

Signed-off-by: yash-zededa <yash@zededa.com>

rename target to collected_sources, output in dist folder

Signed-off-by: yash-zededa <yash@zededa.com>

minor fix in the Makefile syntax and calling the target

Signed-off-by: yash-zededa <yash@zededa.com>

use of single cut expression

Signed-off-by: yash-zededa <yash@zededa.com>

to generate the metadata for the packages used within eve for sBOM needs

Signed-off-by: yash-zededa <yash@zededa.com>

to generate the metadata for the packages used within eve for sBOM needs

Signed-off-by: yash-zededa <yash@zededa.com>
@yash-zededa
Copy link
Collaborator Author

yash-zededa commented Mar 30, 2023 •
edited
Loading

Note that all of the commits should be squashed before we can merge this.

@eriknordmark All commits squashed. Please approve and merge as I don't have access

eriknordmark
eriknordmark approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@yash-zededa yash-zededa requested review from eriknordmark and removed request for rvs and dautovri March 30, 2023 11:52
@eriknordmark eriknordmark merged commit 97f3f49 into lf-edge:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deitch deitch deitch approved these changes

@eriknordmark eriknordmark Awaiting requested review from eriknordmark eriknordmark is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash-zededa @deitch @eriknordmark