Set max ashift to 4K #3122
Merged
Set max ashift to 4K #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zedi-pramodh , I would add the PR short explanation ( |
Sure will do. Does that trigger another round of tests ? Just trying to save resources. |
This will ensure ashift is always set to 4K irrespective of the block size supported by the physical device. Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
zedi-pramodh
force-pushed
the
add-zfs-max-ashift
branch
from
8ea61cb to
b20f03e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set max auto ashift to 4K. This will ensure ashift is always set to 4K irrespective of the block size supported by the physical device.
Testing done
Compiled.
Tested that parameter is set.
Before fix
(ns: pillar) 5e2b3989-174a-450f-ad73-47b021784f28:/sys/module/zfs/parameters# cat zfs_vdev_min_auto_ashift
12
(ns: pillar) 5e2b3989-174a-450f-ad73-47b021784f28:/sys/module/zfs/parameters# cat zfs_vdev_max_auto_ashift
16
After Fix
5e2b3989-174a-450f-ad73-47b021784f28:/sys/module/zfs/parameters# cat zfs_vdev_min_auto_ashift
12
5e2b3989-174a-450f-ad73-47b021784f28:/sys/module/zfs/parameters# cat zfs_vdev_max_auto_ashift
12