Make kernel config diffing less pedantic #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make config diffing less pedantic, this is still sensitive to config changes, but not sensitive to order of the config values which might change by `make prepare`. Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
Make config diffing less pedantic, this is still sensitive to config changes, but not sensitive to order of the config values which might change by `make prepare`. Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
rouming
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Awesome. I hate the annoying diff very much!
@eriknordmark do we have any strict requirement on that diff?
Anyway, looks good to me.
|
#3116 will silence the yetus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any change to local kernel config has to be exactly the same order as the menuconfig output (?) otherwise build fails. This change is still sensitive to config changes, but not sensitive to the order of the config values (which might get changed by
make prepareif not in the exact order of menuconfig).