-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate manifest file from the collected_sources #3153
Conversation
A few requests before a formal review:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the yetus, request to include the manifest inside the tar file.
based on reviews we might have changes in the script or in the makefile. I prefer to squash at once when all the changes are reviewed and approved. will include few lines of output from the manifest file. will check and fix the yetus stuff if possible. |
@yash-zededa for yetus, copy-pasting the script here might help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments plus complaints from shellcheck and blanks from the yetus run.
I think you need to rebase. |
Yes, I have synced the fork |
Yetus is clean! You do need to sign the DCO though |
Your sample manifest in the description is very confusing as it is a single line. Is that what the script outputs? If not, can you fix the description? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; nit about the PR description and the script usage line.
Signed-off-by: yash-zededa <yash@zededa.com> flat directory for collected_source tar file & manifest file for the collected sources Signed-off-by: yash-zededa <yash@zededa.com> minor fix in the makefile, used kernel packages for manifest generation Signed-off-by: yash-zededa <yash@zededa.com> new line at the end Signed-off-by: yash-zededa <yash@zededa.com> added licence info in generate source, moved manifest file to the collected sources tar Signed-off-by: yash-zededa <yash@zededa.com> removed verbose logging Signed-off-by: yash-zededa <yash@zededa.com> retrigger checks Signed-off-by: yash-zededa <yash@zededa.com> minor fixes Signed-off-by: yash-zededa <yash@zededa.com> fixed the script line usage Signed-off-by: yash-zededa <yash@zededa.com>
The script is generating the manifest data per line. For example the above would be one line. |
The PR will do the below:-