Make edgeview status info more reliable #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1472,7 +1479,8 @@ func PublishEdgeviewToZedCloud(ctx *zedagentContext, | |||
| //We queue the message and then get the highest priority message to send. | |||
| //If there are no failures and defers we'll send this message, | |||
| //but if there is a queue we'll retry sending the highest priority message. | |||
| queueInfoToDest(ctx, dest, "global", buf, size, true, false, false, | |||
| // The first update is important, and that informs zedcloud the edgeivew is 'Active' | |||
There was a problem hiding this comment.
This comment would make more sense on line 1454 together with an explanation that the counters are always zero when the first Evinfo is set. Alternatively make it explicitly track whether it is the first one it sends.
There was a problem hiding this comment.
makes sense. updated.
Signed-off-by: Naiming Shen <naiming@zededa.com>
naiming-zededa
force-pushed
the
naiming-edgeview-info
branch
from
13c1b06 to
6a2eb04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise the status stays in 'Activiting' while the edgeview is working on device.
this patch is to make it more reliable.