Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish SBOM and collected_sources #3166

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Publish SBOM and collected_sources #3166

merged 1 commit into from
Apr 29, 2023

Conversation

yash-zededa
Copy link
Collaborator

Description:

  1. To update gitub actions to build the sbom and collected_sources targets.
  2. Copy the files to assets folder
  3. Publish/Release the artifacts under github assets

deitch
deitch requested changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments.

.github/workflows/assets.yml Outdated Show resolved Hide resolved
.github/workflows/assets.yml Outdated Show resolved Hide resolved
@deitch
Copy link
Contributor

deitch commented Apr 28, 2023

@eriknordmark this looks pretty good.

@yash-zededa
publish collected_sources and sbom json under assets
4ff17bb 
Signed-off-by: yash-zededa <yash@zededa.com>

added info targets to get the path of the artifacts created

Signed-off-by: yash-zededa <yash@zededa.com>

removed the echo

Signed-off-by: yash-zededa <yash@zededa.com>

removed the current symlink

Signed-off-by: yash-zededa <yash@zededa.com>

minor fix in the space

Signed-off-by: yash-zededa <yash@zededa.com>

initial commit for sbom and collected_sources artifacts to be published

minor fix

initial commit for sbom and collected_sources artifacts to be published

Signed-off-by: yash-zededa <yash@zededa.com>

fixed spacing

Signed-off-by: yash-zededa <yash@zededa.com>
eriknordmark
eriknordmark approved these changes Apr 29, 2023
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit c003294 into lf-edge:master Apr 29, 2023
eriknordmark
eriknordmark reviewed Apr 29, 2023
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yash-zededa @deitch the master build fails with

build (amd64)ENOENT: no such file or directory, stat 'assets/rootfs.img'

build (arm64)ENOENT: no such file or directory, stat 'assets/rootfs.img'

build (amd64)
ENOENT: no such file or directory, stat 'assets/rootfs.img'
build (arm64)
ENOENT: no such file or directory, stat 'assets/rootfs.img'

See https://github.com/lf-edge/eve/actions/runs/4840159952

Need to either fix this before Monday, or revert this PR.

@deitch
Copy link
Contributor

deitch commented Apr 30, 2023

Please see #3178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriknordmark eriknordmark eriknordmark approved these changes

@deitch deitch deitch approved these changes

@rvs rvs Awaiting requested review from rvs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash-zededa @deitch @eriknordmark