Do not try to resolve with link-local src IP #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milan-zededa
changed the title
ResolveWithPortsLambda would try every IP address assigned to a given port as a source address for a resolution query. However, if port has a link-local IP address assigned, we get lot's of warnings in the log such as this one: [2023-04-28 10:14:42 | 85s] <warning> nim:nim.(*nim).resolveWithPorts resolveWithPortsLambda failed: [dns exchange failed: dial udp: address [fe80::3306:6654:670:beeb]:0: no suitable address found dns exchange failed: dial udp: address [fe80::5d2d:ab19:3624:4ef7]:0: no suitable address found] This can be avoided if ResolveWithPortsLambda skips non-global non-unicast IPs. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
resolve-global-src
branch
from
621ca68 to
88e3613
Compare
|
LGTM - (I hope nobody uses IPv6 NAT) |
@christoph-zededa IPv6 NATs plus only having IPv6 link local addresses is probably asking for trouble, since some host stacks might not allow a link-local source address with a global destination address. |
eriknordmark
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResolveWithPortsLambdawould try every IP address assigned to a given port as a source address for a resolution query. However, if port has a link-local IP address assigned, we get lot's of warnings in the log such as this one:This can be avoided if
ResolveWithPortsLambdaskips non-global non-unicast IPs.CC @christoph-zededa