Check for filesystem existence only, not its type #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no filesystem exists create ext4 fs instead of ext2 Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
|
@zedi-pramodh can you please describe the background of this PR? this is the fix for some bug? |
|
@rouming customer reported an issue where we are creating ext2 filesystem on their raw devices. If you need more info we can discuss internally since its a customer issue. |
|
I think this needs to be patched in LTS releases so I added the stable label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no filesystem exists create ext4 fs instead of ext2
Testing done
Assigned a raw block device to container and verified that ext4 is created on that and mounted at the requested mount point.
Assigned a raw block device which already has a ext4 filesystem and verified that contents on it are intact, ie filesystem is not recreated.