ISO version of the verification image #3197
Conversation
jsfakian
commented
May 8, 2023
jsfakian
commented
- Created new directory pkg/mkverification-iso-efi which is similar
- Renamed extract_verification_info.sh to extract-verification-info.sh for homogeneity
- Added MKISOVERIFICATION_TAG to tools/parse-pkgs.sh
- Added file tools/makeverificationiso.sh which is similar to tools/makeiso.sh
pkg/mkverification-iso-efi/make-efi
Outdated
| -m rootfs-\* -f -R -e boot.img -hide boot.img -hide boot.catalog -no-emul-boot -o /tmp/disk.iso . | ||
| copy /tmp/disk.iso /output.iso | ||
|
|
||
| # How to build a VHDX. Commented out because we are currently not using it |
There was a problem hiding this comment.
This comment is already part of pkg/mkimage-iso-efi/make-efi (from where you took the code), I don't think we need to keep a copy here, you can safely remove it....
pkg/mkverification-iso-efi/make-efi
Outdated
| mmd -i boot.img ::/EFI/BOOT | ||
| mcopy -i boot.img EFI/BOOT/* ::/EFI/BOOT/ | ||
|
|
||
| # pay attentio to the -f option: it follows symlinks which is exactly |
tools/makeverificationiso.sh
Outdated
| @@ -0,0 +1,15 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
Please, include Copyright and SPDX header information.
There was a problem hiding this comment.
Does this end up pushing some image to docker hub? If so, how to we name that image lfedge/eve-... (and we should change the lfedge/mkverification-raw-efi to have an eve prefix.)
Also, need to decide what the names should be for the actual verification images which one will download and run.
It makes sense to check how we do lfedge/eve-*, where we have a single container and its run script takes arguments by which the user can extract/generate a rootfs, an spdx file, a raw or iso installer. I think it makes sense to clone the last part i.e., build a single docker container (e.g., lfedge/eve-verification, or lfedge/eve-hwverification) which can run and output different formats like raw or iso.
There was a problem hiding this comment.
Does this end up pushing some image to docker hub? If so, how to we name that image lfedge/eve-... (and we should change the lfedge/mkverification-raw-efi to have an eve prefix.)
Also, need to decide what the names should be for the actual verification images which one will download and run.
It makes sense to check how we do lfedge/eve-*, where we have a single container and its run script takes arguments by which the user can extract/generate a rootfs, an spdx file, a raw or iso installer. I think it makes sense to clone the last part i.e., build a single docker container (e.g., lfedge/eve-verification, or lfedge/eve-hwverification) which can run and output different formats like raw or iso.
jsfakian
force-pushed
the
WIP-mkverification-iso-efi
branch
4 times, most recently
from
1d17c6c to
e81c4a5
Compare
jsfakian
force-pushed
the
WIP-mkverification-iso-efi
branch
6 times, most recently
from
5fd88c2 to
77d18f2
Compare
I avoided creating a new docker image, I reused the code we have in pkg/mkimage-iso-efi |
pkg/mkimage-iso-efi/Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM lfedge/eve-alpine:9fb9b9cbf7d90066a70e4704d04a6fe248ff52bb AS build | |||
| FROM lfedge/eve-alpine:c114cf1d3ea51534f061f9aa949beb6ac5c12fb3 AS build | |||
There was a problem hiding this comment.
We've updated the most recent tag for eve-alpine. Can you check if this is the correct/current one?
Signed-off-by: Ioannis Sfakianakis <jsfakas@gmail.com>
jsfakian
force-pushed
the
WIP-mkverification-iso-efi
branch
from
77d18f2 to
f1c4951
Compare
