Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compare sbom fix #3198

Merged
merged 1 commit into from
May 8, 2023
Merged

compare sbom fix #3198

merged 1 commit into from
May 8, 2023

Conversation

yash-zededa
Copy link
Collaborator

@yash-zededa yash-zededa commented May 8, 2023 •
edited
Loading

  • the compare sbom and collected sources utility fails reading the csv file when we don't refer the internal path of the file.
    For eg.

/somepath/collected_sources.tar.gz:./collected_sources_manifest.csv

./ is required for the compare utility to read from the archive which acts as an internal path

@yash-zededa
compare sbom fix while reading the csv
db4bc66 
Signed-off-by: yash-zededa <yash@zededa.com>
eriknordmark
eriknordmark approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 32ca7d4 into lf-edge:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriknordmark eriknordmark eriknordmark approved these changes

@rvs rvs Awaiting requested review from rvs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yash-zededa @eriknordmark