compare: read data before file closes #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compare-sources-sbomwas returning a handle to the file inside the tar reader, but returning from a function with adefer.Close()set. That caused the tar or tgz file to close before or while reading, leading to the error:We didn't catch it before because it was intermittent. The whole CSV manifest to be read is ~56KB. That meant that the caller could actually read the file before the closing function (and underlying OS) might have read it. Hence, sometimes it worked, and we got (un)lucky when testing it earlier that it worked.
This fixes it by reading the whole small manifest into memory before returning.
cc @yash-zededa @eriknordmark