Install and use gsed instead of sed on MacOS systems #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
shjala
reviewed
May 15, 2023
tools/kernel-build-yml.sh
Outdated
|
|
||
| if [ "$OS" = "Darwin" ]; then | ||
| #If already installed, that is fine, error message goes to /dev/null | ||
| brew install gnu-sed > /dev/null 2>&1 |
There was a problem hiding this comment.
I suggest adding gnu-sed installation to the readme.md (section "On OSX (using Brew)" ) instead of installing it on the user's system without consent.
There was a problem hiding this comment.
Yeah makes sense. I will modify the commit
There was a problem hiding this comment.
I tested the BSD sed and this seems to be portable between BSD and GNU:
sed -i'' -e "/KBUILD_BUILD_TIMESTAMP/c\ - KBUILD_BUILD_TIMESTAMP=$KBUILD_BUILD_TIMESTAMP" "$k/build.yml"
replace the sed -i with sed -i'' -e, would you please check if this one works on Mac?
There was a problem hiding this comment.
Does not work.
sed: 1: "/KBUILD_BUILD_TIMESTAMP ...": extra characters after \ at the end of c command
Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
shjala
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified that "make pkgs" compilation works and was able to build eve on MacOS.