Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed the version for compare sources utility #3217

Merged
merged 3 commits into from
May 16, 2023
Merged

removed the version for compare sources utility #3217

merged 3 commits into from
May 16, 2023

Conversation

yash-zededa
Copy link
Collaborator

Makefile was referring to the specific commit of the COMPARE SOURCES utility. Since the source code for compare utility is in the eve repo. We are referring the folder to install the utility in the makefile.

Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retracting my LGTM; Erik caught the mistake.

Signed-off-by: yash-zededa <yash@zededa.com>
@yash-zededa
Copy link
Collaborator Author

Retracting my LGTM; Erik caught the mistake.

Fixed that.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work. You removed COMPARESOURCES

Signed-off-by: yash-zededa <yash@zededa.com>
Signed-off-by: yash-zededa <yash@zededa.com>
@eriknordmark eriknordmark merged commit 549a582 into lf-edge:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants