Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OPTEE-OS build #3219

Merged
merged 2 commits into from
May 17, 2023
Merged

Fix OPTEE-OS build #3219

merged 2 commits into from
May 17, 2023

Conversation

rene
Copy link
Contributor

@rene rene commented May 17, 2023

Fix OPTEE-OS build for ARM64 hosts and riscv64 platform.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark
Copy link
Contributor

@rene , the build worked (and I cancelled the eden tests to save on runner capacity).
Should we merge this?

Copy link
Contributor

@mikem-zed mikem-zed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@rene was fixing it yesterday and I participated in discussion.

rene added 2 commits May 17, 2023 17:41
pkg/optee-os/Dockerfile doesn't considered riscv64 platform for cross
compilation. Although the support is currently not available, we should not
break the build process.

Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
armhf compiler must also be installed on ARM64 hosts in order to build ARM
32 bits components of OPTEE-OS.

Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
@rene
Copy link
Contributor Author

rene commented May 17, 2023

Updates in this PR:

  • Rebase on master
  • Add pkg/optee-os on riscv64 dependencies in Makefile in order to get published on dockerhub

@eriknordmark eriknordmark merged commit 3da3106 into lf-edge:master May 17, 2023
@rene rene deleted the fix-optee branch May 24, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants