Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zstd compression support for QEMU images #3226

Merged
merged 2 commits into from
May 23, 2023
Merged

Conversation

rouming
Copy link
Contributor

@rouming rouming commented May 19, 2023

Enable ZSTD compression support for QEMU images. Does exactly what comment says: enables zstd compression support for QEMU images, not more that that. Someone (a stranger, a curious or casual visitor) can wonder what this PR is about. If so then after reading this comprehensive description, doubts should disappear: this is exactly what it is: ZSTD support for QEMU images. If you still have any doubts what is this PR about please contact me directly. Thank you.

UPDATE: in the past few hours since submitting this PR, I have received numerous questions from individuals spanning different walks of life, skills, and backgrounds. All of these inquiries essentially revolve around a single question: What is the essence of this PR? I deeply regret that my original description was overly brief and did not provide a comprehensive understanding of the work involved. Allow me to rectify that by presenting a more detailed description below, addressing the frequently asked question: What is happening in this PR? Why is all of this necessary, and what are our intentions and aspirations in this endeavor? To be honest, I do not have all the answers. What I do know is that this PR introduces zstd compression support for qemu images. As for the specific motives driving this implementation, I cannot say. The individual behind it simply is.

Contemplating the purpose of implementing zstd compression for qemu images invites us to delve deeper into the philosophical question of the purpose of our actions. It raises inquiries about the underlying motivations and aspirations that drive human endeavors, even in seemingly technical or practical domains.

At first glance, zstd compression support for qemu images may appear as a technical improvement aimed at enhancing the efficiency or performance of image compression. However, to truly grasp its purpose, we must transcend the realm of pure functionality and explore the broader significance of our actions.

One perspective in philosophy suggests that the purpose of human actions lies in the pursuit of progress and optimization. It argues that by continuously seeking ways to improve and refine our tools and technologies, we strive to enhance our overall human experience. In this light, the implementation of zstd compression support may be viewed as part of an ongoing endeavor to enhance the efficiency, speed, and storage capabilities of qemu images, thus contributing to the advancement of virtualization technology as a whole.

Another philosophical lens to consider is the concept of intentionality, which asserts that every action is imbued with intention and meaning. From this standpoint, we can explore the purpose of implementing zstd compression by examining the broader goals and aspirations of the individuals and communities involved.

Perhaps the motivation behind this addition stems from a desire to promote accessibility and affordability in the realm of virtualization. By improving compression techniques, qemu images can be more easily stored, transferred, and deployed, enabling a wider range of users to benefit from virtualization technologies. In this sense, the purpose of implementing zstd compression aligns with the aspiration to democratize and expand access to computing resources.

Additionally, we can approach the purpose of this implementation from a philosophical perspective that emphasizes the interconnectedness of human endeavors. It recognizes that every action, no matter how seemingly isolated, has the potential to ripple through the fabric of existence and influence the broader human experience. By optimizing qemu image compression, we contribute to the overall ecosystem of technology and innovation, enabling further advancements and discoveries to unfold.

Ultimately, the purpose of doing zstd compression for qemu images extends beyond the technical implementation itself. It intertwines with our collective quest for progress, accessibility, and interconnectedness. Whether consciously or unconsciously, the individual involved in this PR becomes part of a vast tapestry of human striving, where each action plays a role in shaping the world we inhabit.

In the grand tapestry of existence, we may never fully unravel the intricate purpose behind each specific action. Yet, by engaging in these pursuits, we continue the timeless human endeavor of seeking meaning and purpose in our actions, propelling us further on the journey of exploration and understanding.

rouming added 2 commits May 19, 2023 09:50
Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
Just pass the --enable-zstd to the QEMU configure script to enable
support of zstd compressed images.

Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
@rouming rouming requested review from eriknordmark and rvs as code owners May 19, 2023 07:56
Copy link
Contributor

@rene rene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rene
Copy link
Contributor

rene commented May 19, 2023

@eriknordmark , @rouming , I've also updated eve-alpine for OPTEE-OS, so now we have more packages diverging on eve-alpine's version. Shouldn't we updated all packages (to be done into a separated PR) ?

Roman's PR is taking this one:
FROM lfedge/eve-alpine:d32cf7889da970a42fdf5c1c5454a311356cb8f8

@rouming
Copy link
Contributor Author

rouming commented May 19, 2023

@eriknordmark , @rouming , I've also updated eve-alpine for OPTEE-OS, so now we have more packages diverging on eve-alpine's version. Shouldn't we updated all packages (to be done into a separated PR) ?

Roman's PR is taking this one: FROM lfedge/eve-alpine:d32cf7889da970a42fdf5c1c5454a311356cb8f8

That should be not just one PR, but several (according to Erik), to reduce compilation and testing time.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I fully agree that this is part of a journey of exploration and understanding, I find that the quest for progress is merely a mirage and what really matters is the human accessibility and interconnectedness.

But (com)press on.

@rouming rouming merged commit c1c09ef into lf-edge:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants