Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to pull the image from eve-sources for sbom #3227

Merged
merged 1 commit into from
May 19, 2023
Merged

to pull the image from eve-sources for sbom #3227

merged 1 commit into from
May 19, 2023

Conversation

yash-zededa
Copy link
Collaborator

This MR will pull the image based on the tag from eve-sources dockerhub repo.

 EVE_SOURCES=lfedge/eve-sources:${{ env.TAG }}-${HV}-${{ env.ARCH }}

It will create a new container from the specified image, without starting it. We then use the export command to get the filesystem and store it into assets as tar.gz file.

@eriknordmark eriknordmark requested a review from deitch May 19, 2023 09:23
@eriknordmark eriknordmark changed the title to pull the image from eve-sourcses for sbom to pull the image from eve-sources for sbom May 19, 2023
…to assets

Signed-off-by: yash-zededa <yash@zededa.com>
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As long as you tested the steps manually and it worked, we are good.

@eriknordmark is there any chance this gets run before publish.yml, as it depends on it being there?

I would think not. The only part that had me thinking is the fact that we name one stage "Pull the EVE release from DockerHUB or build it". The "or build it" had me concerned.

@yash-zededa
Copy link
Collaborator Author

yash-zededa commented May 19, 2023

LGTM. As long as you tested the steps manually and it worked, we are good.

@eriknordmark is there any chance this gets run before publish.yml, as it depends on it being there?

I would think not. The only part that had me thinking is the fact that we name one stage "Pull the EVE release from DockerHUB or build it". The "or build it" had me concerned.

Tested it multiple times. It's working as expected.

Local output:

bash-3.2$ #docker export --output /tmp/assets/collected_sources.tar.gz eve_sources
bash-3.2$ rm /tmp/assets/collected_sources.tar.gz 
bash-3.2$ docker export --output /tmp/assets/collected_sources.tar.gz eve_sources
bash-3.2$ echo 4?
4?
bash-3.2$ echo $?
0
bash-3.2$ cd /tmp/assets/
bash-3.2$ ls -tl
total 2097344
-rw-------  1 yash  wheel  1066786816 May 19 14:50 collected_sources.tar.gz
bash-3.2$ date
Fri May 19 14:50:54 CEST 2023

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let's give it a try

@eriknordmark eriknordmark merged commit 82fb8d0 into lf-edge:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants