Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending cellular connectivity APIs #3228

Merged
merged 3 commits into from
May 22, 2023

Conversation

milan-zededa
Copy link
Contributor

@milan-zededa milan-zededa commented May 19, 2023

This commits extends cellular config and status APIs.
With newly introduced API fields it will be possible to:

  • specify username and password for connecting to a cellular network
  • specify preferred cellular network providers
  • specify preferred radio access technologies, aka RATs (GSM, UMTS, LTE, 5GNR)
  • use Dual SIM Single Standby (DSSS) technology
  • forbid roaming
  • get info about modem manufacturer (other modem info already available)
  • get info separately for every SIM slot
  • determine if a given provider is forbidden by SIM card config
  • get port MTU (for any port, not just wwan)
  • get RAT currently used by modem to connect
  • get timestamp of the cellular connection establishment

These features are not yet implemented, meaning that for now EVE will
not read/write these new fields.

CC @mikem-zed @rene

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues/questions plus yetus items to address.

This commits extends cellular config and status APIs.
With newly introduced API fields it will be possible to:
 - specify username and password for connecting to a cellular network
 - specify preferred cellular network providers
 - specify preferred radio access technologies, aka RATs (GSM, UMTS, LTE, 5GNR)
 - use Dual SIM Single Standby (DSSS) technology
 - forbid roaming
 - get info about modem manufacturer (other modem info already
   available)
 - get info separately for every SIM slot
 - determine if a given provider is forbidden by SIM card config
 - get port MTU (for any port, not just wwan)
 - get RAT currently used by modem to connect
 - get timestamp of the cellular connection establishment

These features are not yet implemented, meaning that for now EVE will
not read/write these new fields.

Signed-off-by: Milan Lenco <milan@zededa.com>
Signed-off-by: Milan Lenco <milan@zededa.com>
Signed-off-by: Milan Lenco <milan@zededa.com>
@milan-zededa milan-zededa force-pushed the extend-cellular-apis branch from a39dd4e to 73dc7a7 Compare May 22, 2023 07:37
@milan-zededa
Copy link
Contributor Author

Some minor issues/questions plus yetus items to address.

One thing that Yetus will still complain is that it does not like CELLULAR_AUTH_PROTOCOL_NONE = 0;, but prefers _UNSPECIFIED suffix. However, since the default behavior (unset value) is that there is no authentication protocol used, having _NONE suffix is more clear and explicit I think.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit fa6d8bd into lf-edge:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants