Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update alpine doc #3230

Merged
merged 1 commit into from
May 19, 2023
Merged

update alpine doc #3230

merged 1 commit into from
May 19, 2023

Conversation

deitch
Copy link
Contributor

@deitch deitch commented May 19, 2023

Make it clearer how to update alpine and add packages

@deitch deitch requested review from eriknordmark and rvs as code owners May 19, 2023 12:19
@eriknordmark eriknordmark requested a review from rouming May 19, 2023 12:33
@deitch deitch force-pushed the update-alpine-doc branch 2 times, most recently from 0cd66a3 to e5dd52b Compare May 19, 2023 13:06
@rouming
Copy link
Contributor

rouming commented May 19, 2023

Ack.

Now the procedure looks clear to me, especially the description of where the "dirty" comes from, and that a commit is required for proper hash generation. Thanks for doc update.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but yetus has some issues.

Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch deitch force-pushed the update-alpine-doc branch from e5dd52b to d752bd0 Compare May 19, 2023 13:55
@deitch
Copy link
Contributor Author

deitch commented May 19, 2023

Updated to get the yetus issues

@eriknordmark eriknordmark merged commit 3514c77 into lf-edge:master May 19, 2023
@deitch deitch deleted the update-alpine-doc branch May 21, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants