Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go-sources to calculate go version #3246

Merged
merged 1 commit into from
May 31, 2023

Conversation

deitch
Copy link
Contributor

@deitch deitch commented May 30, 2023

When we get the sources from modules, it is able to get the version/pseufo-version. For pointing at source trees, however, we had no version.

This updates go-sources-and-versions to replicate how go does it, and calculate the actual version (or pseudo-version, if most recent commit is not a version), including it in the name of the file and the manifest.

Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch deitch requested review from eriknordmark and rvs as code owners May 30, 2023 12:21
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 6f5d843 into lf-edge:master May 31, 2023
@deitch deitch deleted the go-sources-with-source-version branch May 31, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants