Makefile: Remove -C flag from go command #3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go 1.20 introduced flag -C, which changes to the directory pointed in the argument before performing the command. Commit 3a5201f started to use -C, breaking the build on systems with go versions lower than 1.20. Many distros (checked Ubuntu and Debian) still don't have package for Go 1.20, requiring manual installation, which can be annoying for users. This commit provides a workaround for this issue. In the future, when distros bump go version to 1.20, this commit can be reverted. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
deitch
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go 1.20 introduced flag -C, which changes to the directory pointed in the argument before performing the command. Commit
3a5201f started to use -C, breaking the build on systems with go versions lower than 1.20. Many distros (checked Ubuntu and Debian) still don't have package for Go 1.20, requiring manual installation, which can be annoying for users. This PR provides a workaround for this issue. In the future, when distros bump go version to 1.20, this commit can be reverted.