-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify networking to enable integration with K3s #3252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some separate detailed comments, but let's kick off tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'd address comment on DNS traffic and perhaps squash this commits while merging, that'll make it easy to rebase just in case
bbf5b95
to
6dc8d8d
Compare
I could squash, but I didn't want the Naiming's contribution to disappear, hence I kept his commits :) |
6cde70b
to
54df19b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run eden again
54df19b
to
483f0bd
Compare
Resolved merge conflicts |
Seems like we have some issues in master causing ztests failures. Let's wait until those are resolved and then retest and merge this PR. |
@milan-zededa Makes sense to rebase this on master so we can get reasonable test results. |
Signed-off-by: Naiming Shen <naiming@zededa.com>
Signed-off-by: Naiming Shen <naiming@zededa.com>
This enables communication between K3s API server (listening on a port IP address) and other K3s components (listening on IPs from the pod subnet). Signed-off-by: Milan Lenco <milan@zededa.com>
483f0bd
to
3c31e47
Compare
@eriknordmark Done, rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run eden
This PR is related to the integration of EVE with K3s (#3210) and covers the networking part.
For now we will support specifically only the (default) Flannel CNI.
It turns out that it is necessary to propagate routes created for Flannel's bridge
cni0
into the per-port routing tables (managed by NIM).