make eve version from file rather than templating #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriknordmark
requested changes
May 31, 2023
|
Resolved the conflict |
|
yetus found some issues, think I addressed. Let it run and see. |
Signed-off-by: Avi Deitcher <avi@deitcher.net>
|
Take 3 on yetus... |
|
yetus likes me now!! |
eriknordmark
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed with @eriknordmark in #3251 , this uses a similar approach, removing templating for the
EVE_VERSIONfromrootfs.yml.inand just reusing a file ininstaller/that already exists.It requires some changes to
makerootfs.shso that it knows what directory to run.