Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split packets into chunks when exceeding pipe buffer size #3272

Merged

Conversation

naiming-zededa
Copy link
Contributor

  • noticed an issue when the ACL entries too large, some of the Edgeview commends
    may hang due to the pipe buffer was full. This patch is to split it into the separate
    chunks if the size is too large.

@naiming-zededa naiming-zededa force-pushed the naiming-edgeview-buffer-pipe branch from 78447e1 to 24d692b Compare June 8, 2023 03:24
@milan-zededa
Copy link
Contributor

@naiming-zededa You probably need to run go fmt ./websocket.go

@naiming-zededa
Copy link
Contributor Author

@naiming-zededa You probably need to run go fmt ./websocket.go

@milan-zededa I did do that, but there is no change at least in my workspace.

Signed-off-by: Naiming Shen <naiming@zededa.com>
@deitch
Copy link
Contributor

deitch commented Jun 8, 2023

Try gofmt -w -s ./websocket.go? Tell it to write in place?

@naiming-zededa
Copy link
Contributor Author

dispatcher [naiming-edgeview-buffer-pipe] ⚡ gofmt -w -s ./wss-server.go
☁ dispatcher [naiming-edgeview-buffer-pipe] ⚡

does not seem to be changed. I'll comment out the wss-server.go in pkg/edgeview/Makefile, since we don't need that

@naiming-zededa naiming-zededa force-pushed the naiming-edgeview-buffer-pipe branch from 24d692b to 0ccfc23 Compare June 8, 2023 17:02
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run eden

@eriknordmark eriknordmark merged commit 0f27f95 into lf-edge:master Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants