zedrouter/appcontainer: fix connectivity to the VM docker #3273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From some version of the docker/client library the .NewClient() call was deprecated, which caused the following error: "getAppContainers: Container list error Cannot connect to the Docker daemon at tcp://$IP:2375. Is the docker daemon running?" because by default the connectivity was established through the unix docker.sock socket. This patch fixes the problem by passing the HTTP client to the constructor of the docker client. The main motiviation of this fix is the "Unknown" state of "Modules" visible on the UI of the controller, because statistics was never collected from the docker. Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
milan-zededa
approved these changes
Jun 8, 2023
|
Sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From some version of the docker/client library the .NewClient() call was deprecated, which caused the following error:
"getAppContainers: Container list error Cannot connect to the Docker daemon at tcp://$IP:2375. Is the docker daemon running?"
because by default the connectivity was established through the unix docker.sock socket.
This patch fixes the problem by passing the HTTP client to the constructor of the docker client.
The main motivation of this fix is the "Unknown" state of "Modules" visible on the UI of the controller, because statistics was never collected from the docker.
cc: @naiming-zededa