-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle realpath in makerootfs.sh sanely #3274
Conversation
bb126d6
to
f7660df
Compare
I removed my symlink workaround and tried the build, works great. Thanks |
Why can't we always do this if it gives the same result? |
No idea. I guess we could. I will try it and update. |
Signed-off-by: Avi Deitcher <avi@deitcher.net>
OK, updated |
Latest changes are still a working build on my machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If realpath is removed then we do not need the commit. You might as well revert that commit. commit bbce625
|
That commit isn't in here. |
I know I did that. But since you are removing realpath you might as remove the prerequisites of coreutils for the MAC. |
No problem @zedi-pramodh ; done. |
This reverts commit bbce625. Signed-off-by: Avi Deitcher <avi@deitcher.net>
c9b573a
to
524f452
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run eden
We use
realpath
inmakerootfs.sh
to find the absolute path to various elements. Unfortunately, that has two shortcomings:realpath
is not available on all systems, mainly some Macrealpath
is available, we run it against a filename that may not yet exist. Some systems will resolve it, but others will error out.This updates
makerootfs.sh
to handle those cases sanely. Instead ofrealpath
the target file, werealpath
the parent directory.If
realpath
does not exist, we fall back tocd $parent && pwd -P
, which gives the same result.