pkg: grub: Replace echo command by true command #3283
Conversation
The load_hv_cmd variable present in EVE's GRUB config points to the command used to load a hypervisor. However, in case of "kvm" and "kubervirt" this command is not needed and it's just translated to an echo command. However, this approach will make messages like the following to appear during a KVM based boot: /boot/xen.gz console=com1 smt=false clocksource=pit dom0_mem=800M,max:800M dom0_max_vcpus=1 dom0_vcpus_pin This can lead to misunderstandings and confusion since a Xen's boot command line it's being printed on a KVM's system. This commit replaces echo by true command. The true command can receive any number of arguments and will always return true without any printing, so no Xen's boot command line will be printed in "kvm" or "kubevirt" cases. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
|
I'm wondering if this modification will have any impact on the bootargs. It's important to note that even in a KVM environment, the dom0_* arguments are required because they are utilized by the system's startup scripts. For example: |
@OhmSpectator , I don't see how this change could impact on dom0_* arguments because the boot entry will just execute an echo command for load_hv_cmd (https://github.com/lf-edge/eve/blob/master/pkg/grub/rootfs.cfg#L397). The line right after is the one which loads the dom0 (just linux in case of KVM) with all dom0_ * arguments... |
I just had to ask that to be sure. Thanks! |
The load_hv_cmd variable present in EVE's GRUB config points to the command used to load a hypervisor. However, in case of "kvm" and "kubervirt" this command is not needed and it's just translated to an echo command. However, this approach will make messages like the following to appear during a KVM based boot:
/boot/xen.gz console=com1 smt=false clocksource=pit dom0_mem=800M,max:800M dom0_max_vcpus=1 dom0_vcpus_pinThis can lead to misunderstandings and confusion since a Xen's boot command line it's being printed on a KVM's system.
This commit replaces echo by true command. The true command can receive any number of arguments and will always return true without any printing, so no Xen's boot command line will be printed in "kvm" or "kubevirt" cases.