Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest linuxkit upstream packages that include main.Version #3285

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

deitch
Copy link
Contributor

@deitch deitch commented Jun 16, 2023

Upstreamed to linuxkit binaries built with go, in packages, to include the same GOPKGVERSION we do in eve, so that source collectors and syft can find the versions for the root module.

Hold on merge until I can run local tests proving it works.

Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch deitch requested review from eriknordmark and rvs as code owners June 16, 2023 09:29
@deitch
Copy link
Contributor Author

deitch commented Jun 16, 2023

It works for all except for runc. So let's hold on this. Going to move to draft until upstream is complete.

@deitch deitch marked this pull request as draft June 16, 2023 10:08
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deitch
Copy link
Contributor Author

deitch commented Jun 16, 2023

I'm going to remove it from draft. It fixes everything except runc, and that's an upstream issue that might take time.

@deitch deitch marked this pull request as ready for review June 16, 2023 12:21
@deitch
Copy link
Contributor Author

deitch commented Jun 16, 2023

Transient error. Please kick off the jobs again.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run eden again

@eriknordmark eriknordmark merged commit b346d26 into lf-edge:master Jun 18, 2023
@deitch deitch deleted the upstream-lkt-with-versions branch June 18, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants