Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the input image size when running makeflash.sh #3299

Conversation

jsfakian
Copy link
Contributor

@jsfakian jsfakian commented Jun 22, 2023

  • When we create live and installer images with the latest version of master, we make it with less size than necessary. There was a previous commit (719b4d5) that increased the rootfs image size, which also required the corresponding change in the Makefile.

Without this fix 'make live run' would fail.

- When we create live and installer image with the latest version
of master, we create it with less size than necessary. There was
a previous commit that increased the rootfs image size, which
required also the correspoding change in the Makefile.

Signed-off-by: Ioannis Sfakianakis <jsfakas@gmail.com>
@jsfakian jsfakian force-pushed the BUG-fix-makefile-rule-for-live-and-installer branch from f0330d2 to 806a3f1 Compare June 22, 2023 11:41
@rene rene requested a review from zedi-pramodh June 22, 2023 12:09
@rene
Copy link
Contributor

rene commented Jun 22, 2023

@jsfakian , regarding the commit you mentioned, please, include the commit ID in your commit message instead of "previous commit". I think would be nice to put some log in the PR's description. For instance, currently make live is broken, image generation is failing due to the problems mentioned in the PR:

...
/rene/workspace/eve/dist/arm64/v7.4.0-master-private-1272-ge60f31abc/installer" || :
./tools/makeflash.sh -C 350 /home/rene/workspace/eve/dist/arm64/v7.4.0-master-private-1272-ge60f31abc/installer /home/rene/workspace/eve/dist/arm64/v7.4.0-master-private-1272-ge60f31abc/live.raw efi conf imga
1+0 records in
1+0 records out
1 byte copied, 0.00010789 s, 9.3 kB/s
Unknown (or unrecognizable) GPT partition table on /output.img
1+0 records in
1+0 records out
512 bytes copied, 5.4994e-05 s, 9.3 MB/s
Creating new GPT entries in memory.
GPT data structures destroyed! You may now partition the disk using fdisk or
other utilities.
mkfs.fat 4.2 (2021-01-31)
/tmp/data/tmp.ywWcgTHBIM has 8 heads and 32 sectors per track,
hidden sectors 0x0000;
logical sector size is 512,
using 0xf8 media descriptor, with 73696 sectors;
drive number 0x80;
filesystem has 2 32-bit FATs and 1 sector per cluster.
FAT size is 567 sectors, and provides 72530 clusters.
There are 32 reserved sectors.
Volume ID is 2d074d4c, volume label EVE.
35+1 records in
35+1 records out
37747712 bytes (38 MB, 36 MiB) copied, 0.0535561 s, 705 MB/s
1+0 records in
1+0 records out
1048576 bytes (1.0 MB, 1.0 MiB) copied, 0.00184183 s, 569 MB/s
make: *** [Makefile:730: /home/rene/workspace/eve/dist/arm64/v7.4.0-master-private-1272-ge60f31abc/live.raw] Error 4

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit efbb17b into lf-edge:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants