hypervisor/kvm: Fix serial device access for ARM #3300
Conversation
|
Great, nobody did that on ARM :) Did you have a chance to test the attach of the serial port and reading/writing the data? Also would it make sense to change to the pci-serial on x86 as well? |
|
BTW, there is eden test which covers serial attach: https://github.com/lf-edge/eden/blob/master/tests/eclient/testdata/com-pt_test.txt |
@rouming, I think it does make sense to change pci-serial on x86 as well. However, I prefer to do it into a new PR since it can break VMs without support to serial over PCI, better test more before merge. Let's keep only ARM changes here, since they are critical for now.... |
pkg/pillar/hypervisor/kvm.go
Outdated
| {{- if ne .Machine "virt"}} | ||
| backend = "tty" | ||
| {{- else}} | ||
| backend = "serial" | ||
| {{- end}} |
There was a problem hiding this comment.
What about having it without double negation?
| {{- if ne .Machine "virt"}} | |
| backend = "tty" | |
| {{- else}} | |
| backend = "serial" | |
| {{- end}} | |
| backend = "tty" | |
| {{- if eq .Machine "virt"}} | |
| backend = "serial" | |
| {{- end}} |
There was a problem hiding this comment.
do you mean like this?
{{- if eq .Machine "virt"}}
backend = "serial"
{{- else}}
backend = "tty"
{{- end}}
There was a problem hiding this comment.
@rene are you swapping the code per the above?
There was a problem hiding this comment.
Yes @eriknordmark , it's done.
The QEMU's virt machine model (ARM64) doesn't support isa-serial emulation, so guests cannot access serial devices of the host. This commit fixes this issue changing emulation to pci-serial only for the virt machine model. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
|
Updates in this PR:
|
The QEMU's virt machine model (ARM64) doesn't support isa-serial emulation, so guests cannot access serial devices of the host. This commit fixes this issue changing emulation to pci-serial only for the virt machine model.
Error message from the logs: