Netdump enhancements #3307
Netdump enhancements #3307
Conversation
This can be useful to troubleshoot download failures caused by MITM changing the HTTP header fields (proxy, CDN, etc.). The option is disabled by default becase HTTP header field values may contain sensitive information, such as datastore credentials. Signed-off-by: Milan Lenco <milan@zededa.com>
| lastNetdumpAge := time.Since(ctx.lastInfoNetdumpPub) | ||
| // Ensure we get at least one netdump for the currently tested EVE upgrade. | ||
| if zboot.IsCurrentPartitionStateInProgress() && | ||
| (ctx.lastInfoNetdumpPub.IsZero() || lastNetdumpAge > uptime) { |
There was a problem hiding this comment.
What will happen if EVE will reboot during download in process?
There was a problem hiding this comment.
Netdump is collected after download completes. So if interrupted, EVE would restart download and netdump would be collected afterwards. Note that for downloader microservice we always collect netdumps - this change is for zedagent and nim to collect at least one netdump for requests towards the controller during upgrade. With reboot during upgrade we may end up collecting more, but that is OK. Not having any netdump for failed upgrade would be a problem.
There was a problem hiding this comment.
@uncleDecart Will you please re-approve? Somehow adding comments makes eden tests skipped :/
There was a problem hiding this comment.
Great and in case of reboot it'll be 2 different logs which we will be able to differentiate
Don't worry, I have two larger PRs coming up ;) |
|
@uncleDecart Eden really does not like you ಥ‿ಥ |
| @@ -1087,8 +1088,15 @@ func traceNextConfigReq(ctx *zedagentContext) bool { | |||
| if !isNettraceEnabled(ctx) { | |||
There was a problem hiding this comment.
Looks like this and the corresponding info function only differ in the last*NetdumpPub they check and the functions are getting more complicated. Would it make sense to introduce a common function?
There was a problem hiding this comment.
Makes sense - done
milan-zededa
force-pushed
the
netdump-enhancements
branch
from
3fb6ac6 to
ff66cd5
Compare
If upgrade fails, the recorded netdumps will remain persisted and available for retrieval from the older EVE version. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
netdump-enhancements
branch
from
ff66cd5 to
eb1e506
Compare
|
@uncleDecart Could you please hit approve again to trigger eden tests :) |
Two small commits with netdump enhancements that could be useful for troubleshooting of customer issues.
netdump: Add option to capture HTTP field values for download requests
This can be useful to troubleshoot download failures caused by MITM
changing the HTTP header fields (proxy, CDN, etc.).
The option is disabled by default becase HTTP header field values may contain
sensitive information, such as datastore credentials.
Ensure we get at least one netdump in each topic for tested EVE upgrade
If upgrade fails, the recorded netdumps will remain persisted and
available for retrieval from the older EVE version.