Reconciler: improvements for processing of async operations #3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriknordmark
reviewed
Jul 3, 2023
eriknordmark
reviewed
Jul 3, 2023
|
Note that since this is only in libs, it has no effect on EVE until I bring these changes to pillar in the next PR. So it does not make much sense to wait for eden. |
eriknordmark
approved these changes
Jul 4, 2023
Signed-off-by: Milan Lenco <milan@zededa.com>
Signed-off-by: Milan Lenco <milan@zededa.com>
Async ops that finalize *during* reconciliation are left to be processed in the next reconciliation run. This prevents race-conditions and simplifies the reconciliation algorithm. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
reconciler-async
branch
from
ea56afb to
b05ff57
Compare
uncleDecart
approved these changes
Jul 4, 2023
| WaitForAsyncOps func() | ||
| } | ||
|
|
||
| // CancelFunc is used to cancel all or only some asynchronously running operations. | ||
| type CancelFunc func(cancelForItem func(ref dg.ItemRef) bool) |
There was a problem hiding this comment.
Why don't we want to use semantics of Cancel function defined by context?
There was a problem hiding this comment.
Previously I used that (see the diff) but I needed to add cancelForItem argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 commits in this PR related to reconciliation of async operations:
in the next reconciliation run (some race conditions were found during zedrouter testing and this way they can be easily avoided)
This updates
libs/reconcilerpackage. Changes made here will be propagated to pillar in the next PR together with some zedrouter patches.