Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes: documentation + source code comments #3335

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

rene
Copy link
Contributor

@rene rene commented Jul 11, 2023

  • Provide small fixes in documentation files to make yetus markdownlint pass successfully again
  • Update the documentation about containers, which was completely outdated
  • Fix a small comment in the source code to correspond to the current implementation

rene added 3 commits July 11, 2023 11:41
Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
The contents of docs/CONTAINERS.md is outdated. This commit adds some
updated information about container support on EVE.

Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
Fix comment to correspond to the current implementation: environment
variables should have the format Key1=Val1 in cloud-init configuration
and not Key1:Val1, as pointed by the comment.

Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
@rene rene requested review from eriknordmark and rvs as code owners July 11, 2023 09:48
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 5fa7da2 into lf-edge:master Jul 11, 2023
@rene rene deleted the update-doc branch November 2, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants