[10.4 stable] Do not fail SealDiskKey if PCRs/eventlog can not be saved #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reasons /hostfs/sys/kernel/security/tpm* might not exist on boot but that shouldn't cause tpmmgr to think that the seal failed. Signed-off-by: eriknordmark <erik@zededa.com> (cherry picked from commit 23da4f2)
|
@shjala could users trip on this issue in 10.4.3 (which doesn't have this PR) for a kvm kernel? Or is this mostly to handle odd cases where the BIOS does not publish the event log? |
|
FWIW the logs from the failing devices have getMappedTpmsPath failed: found no TPM in sysfs when running with Xen. |
|
@eriknordmark will jenkins pick this up? |
|
Will merge this, I see xen tests pass in jenkins. Thanks @eriknordmark @shjala |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgotten commit to the stable branch:
Might fix a ztests xen regression. Commit pointed by @shjala . Let's wait how it goes.