-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile to build dockerfile-add-scaned as docker image #3487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. We need to have some way to make deploying te image part of a pipeline as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except the use of latest golang.
4fe57ba
to
aff9612
Compare
We need this to to run in eve-kernel repo to generate spdx.json file Signed-off-by: Mikhail Malyshev <mikem@zededa.com>
aff9612
to
48cf7ea
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3487 +/- ##
==========================================
- Coverage 20.54% 20.54% -0.01%
==========================================
Files 202 202
Lines 45605 45605
==========================================
- Hits 9371 9368 -3
- Misses 35533 35535 +2
- Partials 701 702 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We need this tool to run in eve-kernel repo to generate spdx.json file
Someone (@eriknordmark ?) with permissions should build the image and push it to lf-edge docker hub