Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile to build dockerfile-add-scaned as docker image #3487

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

mikem-zed
Copy link
Contributor

@mikem-zed mikem-zed commented Oct 10, 2023

We need this tool to run in eve-kernel repo to generate spdx.json file
Someone (@eriknordmark ?) with permissions should build the image and push it to lf-edge docker hub

Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. We need to have some way to make deploying te image part of a pipeline as well.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except the use of latest golang.

@mikem-zed mikem-zed force-pushed the mikem/add-scaner-image branch from 4fe57ba to aff9612 Compare October 11, 2023 10:43
We need this to to run in eve-kernel repo to generate spdx.json file

Signed-off-by: Mikhail Malyshev <mikem@zededa.com>
@mikem-zed mikem-zed force-pushed the mikem/add-scaner-image branch from aff9612 to 48cf7ea Compare October 11, 2023 10:44
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e1538b5) 20.54% compared to head (48cf7ea) 20.54%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3487      +/-   ##
==========================================
- Coverage   20.54%   20.54%   -0.01%     
==========================================
  Files         202      202              
  Lines       45605    45605              
==========================================
- Hits         9371     9368       -3     
- Misses      35533    35535       +2     
- Partials      701      702       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit d611aad into lf-edge:master Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants