Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: slice loop replace #3488

Merged
merged 1 commit into from
Oct 11, 2023
Merged

chore: slice loop replace #3488

merged 1 commit into from
Oct 11, 2023

Conversation

testwill
Copy link
Contributor

No description provided.

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
Copy link
Contributor

@rouming rouming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7d52c8a) 20.54% compared to head (a7b267a) 20.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3488   +/-   ##
=======================================
  Coverage   20.54%   20.54%           
=======================================
  Files         202      202           
  Lines       45605    45603    -2     
=======================================
  Hits         9368     9368           
+ Misses      35535    35533    -2     
  Partials      702      702           
Files Coverage Δ
pkg/pillar/types/zedroutertypes.go 16.43% <0.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rouming
Copy link
Contributor

rouming commented Oct 11, 2023

@testwill I will appreciate if you add a minor description to the PR itself. Thanks.

@eriknordmark eriknordmark merged commit 1435cc9 into lf-edge:master Oct 11, 2023
@testwill testwill deleted the slice branch October 12, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants