diskmetrics: increase timeout of qemu img convert #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this partially reverts 193147f during testing it has been found out that the timeout is too short, therefore it is now set again to 5 days Signed-off-by: Christoph Ostarek <christoph@zededa.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3509 +/- ##
==========================================
- Coverage 20.51% 20.49% -0.02%
==========================================
Files 203 203
Lines 45430 45430
==========================================
- Hits 9319 9311 -8
- Misses 35430 35438 +8
Partials 681 681 ☔ View full report in Codecov by Sentry. |
christoph-zededa
changed the title
|
@rouming did someone check whether the failure in the storage test suite (zfs) in https://github.com/lf-edge/eve/actions/runs/6592602265/job/17923425921?pr=3509 can be due to the changes in this PR? I see that test passing on other PRs but here it failed even after a re-run |
|
@eriknordmark I did not check, but IMO 8 minutes (the timeout set before this fix) should be enough for test images. I assume in our tests we don't use terabytes images which require >8min conversion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diskmetrics: increase timeout of qemu img convert