collect-info.sh: add debug info from ModemManager #3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncleDecart
approved these changes
Oct 20, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3511 +/- ##
==========================================
+ Coverage 20.48% 20.50% +0.02%
==========================================
Files 203 203
Lines 45440 45440
==========================================
+ Hits 9309 9319 +10
+ Misses 35448 35440 -8
+ Partials 683 681 -2 ☔ View full report in Codecov by Sentry. |
milan-zededa
force-pushed
the
collect-wwan-info
branch
from
dcb58c4 to
9ed1b8e
Compare
rene
reviewed
Oct 20, 2023
rouming
reviewed
Oct 20, 2023
| @@ -8,7 +8,7 @@ help() { | |||
| Welcome to EVE! | |||
| commands: enter [service] [command (assumed sh)] | |||
| enter-user-app <service> | |||
| exec [service] command | |||
| exec [--fork] [service] command | |||
There was a problem hiding this comment.
I see option '--fork' but not '--no-fork' as commit msg says.
Some commands, such as mmcli from the wwan container, need to create child processes and expect that child and parent processes will be in the same process namespace. However, if command with such expectations is run under nsenter, it is necessary to fork after entering the namespace, so that the parent process of the executed command is inside the target namespace as well and not just its children. Signed-off-by: Milan Lenco <milan@zededa.com>
Even though we already collect pubsub messages published by mmagent from the wwan microservice (WwanStatus, WwanMetrics, WwanLocationInfo), it can still be useful for troubleshooting to collect detailed (and some additional) info about modems, SIMs and bearers directly from the ModemManager. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
collect-wwan-info
branch
from
9ed1b8e to
facbdae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we already collect pubsub messages published by mmagent from the wwan microservice (WwanStatus, WwanMetrics, WwanLocationInfo), it can still be useful for troubleshooting to collect detailed (and some additional) info about modems, SIMs and bearers directly from the ModemManager.
For this to work I had to enable running
eve execwith process forked by nsenter, see the first commit description.