Move types not used by zedrouter out of zedroutertypes.go #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriknordmark
approved these changes
Oct 23, 2023
I'm on it. Will restart other failed workflows once this is fixed: golang/go#63684 |
|
LGTM, this is not related to this PR, but unit tests started to fail |
This is due to golang/go#63684 |
milan-zededa
force-pushed
the
split-zedrouter-types
branch
from
785647d to
7a11a31
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3513 +/- ##
==========================================
- Coverage 20.51% 20.50% -0.01%
==========================================
Files 203 209 +6
Lines 45430 45391 -39
==========================================
- Hits 9319 9308 -11
+ Misses 35430 35401 -29
- Partials 681 682 +1
☔ View full report in Codecov by Sentry. |
zedroutertypes.go currently contains all types related to networking, including those which are actually used from NIM. This makes the file very long and hard to work with. In this commit, we take types not used from zedrouter out of zedroutertypes.go and move them into separate Go files. Apart from moving type definitions and their methods around, there are no actual code changes made here. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
split-zedrouter-types
branch
from
7a11a31 to
f70d710
Compare
|
All relevant Yetus issues have been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zedroutertypes.gocurrently contains all types related to networking, including those which are actually used from NIM. This makes the file very long and hard to work with. In this commit, we take types not used from zedrouter out ofzedroutertypes.goand move them into separate Go files. Apart from moving type definitions and their methods around, there are no actual code changes made here.