Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QEMU_EVE_SERIAL variable to override SMBIOS serial number #3543

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

rucoder
Copy link
Contributor

@rucoder rucoder commented Oct 29, 2023

When we need to override QEMU serial number it is more convenient to use a variable on make command line

When we need to override QEMU serial number it is more convenient
to use a variable on make command line

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
@rucoder rucoder requested a review from eriknordmark as a code owner October 29, 2023 01:15
@rucoder rucoder requested review from rene and europaul October 29, 2023 01:16
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (660a31a) 19.16% compared to head (42cce0e) 19.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3543   +/-   ##
=======================================
  Coverage   19.16%   19.17%           
=======================================
  Files         221      221           
  Lines       49195    49195           
=======================================
+ Hits         9429     9432    +3     
+ Misses      39072    39067    -5     
- Partials      694      696    +2     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit fe3146d into lf-edge:master Oct 30, 2023
24 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants