Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yetus errors and remove deprecated documentation #3622

Merged
merged 4 commits into from
Nov 25, 2023

Conversation

rene
Copy link
Contributor

@rene rene commented Nov 22, 2023

This PR fixes some yetus errors from codespell plugin and takes the opportunity to remove some deprecated information from documentation.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06a3e4e) 19.39% compared to head (71515af) 19.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3622      +/-   ##
==========================================
- Coverage   19.39%   19.38%   -0.01%     
==========================================
  Files         232      232              
  Lines       50494    50494              
==========================================
- Hits         9792     9787       -5     
- Misses      39990    39994       +4     
- Partials      712      713       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you included the fixes to the typos which @mishrasamiksha found can you add credits to the PR for that?

rene and others added 4 commits November 23, 2023 12:24
Fix yetus errors from codespell plugin on README.md and other documentation
files.

Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
Fix yetus errors from codespell plugin.

Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
Remove some deprecated information from documentation.

Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
Reviewed-by: Renê de Souza Pinto <rene@renesp.com.br>
Signed-off-by: Samiksha Mishra <38784342+mishrasamiksha@users.noreply.github.com>
@rene
Copy link
Contributor Author

rene commented Nov 23, 2023

If you included the fixes to the typos which @mishrasamiksha found can you add credits to the PR for that?

I didn't pick her changes, I followed errors from yetus and fix one by one, but you are right, since she pointed out first, it's fair to pick her commit and give her the credits... I've update the PR with her commit, but I couldn't find her email address, so I let the fake one from GH....

Copy link
Contributor

@rucoder rucoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit c9a4cec into lf-edge:master Nov 25, 2023
24 of 29 checks passed
@rene rene deleted the fix-yetus-errors branch November 28, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants