Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to swtpm for running TPM tests #3624

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

shjala
Copy link
Member

@shjala shjala commented Nov 23, 2023

This PR replaces current TPM testing script, which is a bit extra (spawning a whole ubuntu VM to run TPM required test), with just using swtpm. It's clean and fast.

@shjala shjala requested a review from eriknordmark as a code owner November 23, 2023 12:00
@shjala shjala changed the title [WIP] test new way of testing [WIP] test new way of testing TPM required tests Nov 23, 2023
@shjala shjala marked this pull request as draft November 23, 2023 12:01
@github-actions github-actions bot requested a review from rucoder November 23, 2023 12:01
@shjala shjala force-pushed the swtpm_unit_tests branch 6 times, most recently from 1435c37 to 65762e4 Compare November 23, 2023 15:44
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06a3e4e) 19.39% compared to head (2256de5) 19.40%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3624      +/-   ##
==========================================
+ Coverage   19.39%   19.40%   +0.01%     
==========================================
  Files         232      232              
  Lines       50494    50494              
==========================================
+ Hits         9792     9799       +7     
+ Misses      39990    39984       -6     
+ Partials      712      711       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot requested review from deitch and jsfakian November 23, 2023 15:58
@shjala shjala force-pushed the swtpm_unit_tests branch 3 times, most recently from 73e2321 to 11d6d48 Compare November 23, 2023 19:16
@shjala shjala changed the title [WIP] test new way of testing TPM required tests Switch to swtp for running TPM tests Nov 23, 2023
@shjala shjala force-pushed the swtpm_unit_tests branch 2 times, most recently from 4668617 to 1908c88 Compare November 23, 2023 19:52
@shjala shjala changed the title Switch to swtp for running TPM tests Switch to swtpm for running TPM tests Nov 23, 2023
@shjala shjala marked this pull request as ready for review November 23, 2023 19:56
Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
@shjala
Copy link
Member Author

shjala commented Nov 24, 2023

as suggested by @christoph-zededa , I will try to make it part of the "Test" job.

Copy link
Contributor

@rucoder rucoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,107 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First line is blank hence the bin/bash will be ignored I think.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 9589a8e into lf-edge:master Nov 27, 2023
42 of 51 checks passed
@shjala shjala deleted the swtpm_unit_tests branch December 6, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants