-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to swtpm for running TPM tests #3624
Conversation
1435c37
to
65762e4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3624 +/- ##
==========================================
+ Coverage 19.39% 19.40% +0.01%
==========================================
Files 232 232
Lines 50494 50494
==========================================
+ Hits 9792 9799 +7
+ Misses 39990 39984 -6
+ Partials 712 711 -1 ☔ View full report in Codecov by Sentry. |
65762e4
to
c0ddd10
Compare
73e2321
to
11d6d48
Compare
4668617
to
1908c88
Compare
Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
1908c88
to
2256de5
Compare
as suggested by @christoph-zededa , I will try to make it part of the "Test" job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -0,0 +1,107 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First line is blank hence the bin/bash will be ignored I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR replaces current TPM testing script, which is a bit extra (spawning a whole ubuntu VM to run TPM required test), with just using swtpm. It's clean and fast.