[9.4-stable] Backport #3607 (eventlog entries from measure-config) #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Event This commit introduces the following changes: There is no need to hash the event string sent to PCREvent beforehand, it will get hashed internally by all hash algorithms associated with the PCR. PCREvent accepts a maximum of 1024 bytes of event data, to comply break down the event data into chunks of 1024, if the data is larger than 1024 bytes. Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
Don't loop over event data if is longer that 1024 bytes, truncate it and just do it once. This helps with having one event per measurements. Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
We are explicitly using tpm0 all over the place, so simplify the code by removing parts that account for multiple tmp existing on the device and just use tpm0 instead. Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
Create a TCG formatted event log based on the measure-config measurements, we append this file to the end of the system TPM event log when eve fails to unlock the vault, this way we have more information about what possibly went wrong. Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
eriknordmark
reviewed
Dec 8, 2023
|
Yes, for troubleshooting PCR-14 mismatches, without these changes anything measure-config measures won't be part of the TPM event log. |
|
The three yetus complaints are in unmodified code so ignoring them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is backport of #3607 .